Disallow using syntax-form identifiers as variables. #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present things like `(when if ...)` are legal syntax, with the `if` interpreted as a variable reference bound to to an unusable internal value. This is quite wrong, but the behavior was used in a couple places. Fixes ion-fusion#126
This needs to be in a separate module because `define_syntax` bodies are compiled before `define`s are expanded, so they cannot reference helpers from the same module. Racket has `define_for_syntax` to create helpers at the correct expansion phase.
SharkBaitDLS
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present things like
(when if ...)are legal syntax, with theifinterpreted as a variable reference bound to to an unusable internal value. This is quite wrong, but the behavior was used in a couple places.Fixes #126
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.