Update to latest matchms, gensim and poetry buildsystem #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-SpectrumDocument' into compatability-updates
hechth
changed the title
Collaborator
Author
|
@niekdejonge this is ready for review |
Collaborator
Author
|
@hechth This is currently stalled as it is waiting for Gensim 4.4 which should be compatible with numpy>2 and scipy>1.14, which will bring the gensim dependencies in line with matchms dependencies. Then this PR can be merged and spec2vec can be finally updated. |
Collaborator
|
@hechth @niekdejonge gensim 4.4.0 with numpy 2 and Python 3.13 is out (not on conda yet). I added a PR to update versions. Tests are passing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #93, #90, #74 and also #64 .
This includes the new poetry buildsystem for spec2vec as well as an update to work with the latest version of matchms.
I also added support for sparse computations.
So I think once this PR is merged all other PRs can be closed.