Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 13, 2025

  • Add repoReadTime?: string field to the RepoInfo interface in packages/types-dev/objects.d.ts
  • Add appropriate JSDoc documentation: "Time when repository was last read/fetched"
  • Revert auto-generated documentation changes to keep only the essential typing change
  • Revert package-lock.json changes to maintain minimal PR scope

Changes Made

  • Added repoReadTime?: string field to the RepoInfo interface in packages/types-dev/objects.d.ts
  • The field is optional (using ?) and follows the same pattern as the existing repoTime field
  • Added appropriate JSDoc documentation: "Time when repository was last read/fetched"
  • Reverted auto-generated documentation changes to keep only the essential typing change
  • Reverted package-lock.json changes to maintain minimal PR scope

Technical Details

The RepoInfo interface now includes:

  • stable?: boolean - If it is the official stable repository
  • name: Required<ioBroker.Translated> - i18n name of the repository
  • repoTime: string - Time of repository update
  • repoReadTime?: string - Time when repository was last read/fetched (new)

This change maintains backward compatibility as the new field is optional, and follows the existing coding patterns in the codebase. The PR contains only the minimal necessary change (1 file, 2 lines added) to avoid triggering a massive repository rebuild.

Fixes #3101.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@Copilot Copilot AI changed the title [WIP] [enhancement]: Typing for new field in repository Add repoReadTime field to RepoInfo interface for repository read timing Sep 13, 2025
@Copilot Copilot AI requested a review from GermanBluefox September 13, 2025 10:25
Copilot finished work on behalf of GermanBluefox September 13, 2025 10:25
@GermanBluefox GermanBluefox marked this pull request as ready for review September 13, 2025 10:34
@GermanBluefox
Copy link
Contributor

@copilot do not rebuild repository, as it is impossible to detect relevant changes in 300 files. The repository will be rebuilt when publishing

Copy link
Contributor Author

Copilot AI commented Sep 13, 2025

@copilot do not rebuild repository, as it is impossible to detect relevant changes in 300 files. The repository will be rebuilt when publishing

Done! I've reverted all the auto-generated documentation changes and kept only the essential typing change to packages/types-dev/objects.d.ts. The PR now contains only 1 file with 2 lines added for the repoReadTime field. See commit 614891b.

Copilot finished work on behalf of GermanBluefox September 13, 2025 10:41
Copy link
Contributor

@GermanBluefox GermanBluefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please revert the package-lock.json file. this should not change

Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Revert the changes to the package-lock.json file

Copy link
Contributor Author

Copilot AI commented Sep 14, 2025

@copilot Revert the changes to the package-lock.json file

Done! The package-lock.json changes have been reverted. See commit 11e1b97.

Copy link
Contributor Author

Copilot AI commented Sep 14, 2025

@copilot Please revert the package-lock.json file. this should not change

Reverted the package-lock.json file to its original state. See commit 11e1b97.

Copilot finished work on behalf of Apollon77 September 14, 2025 15:55
@Copilot Copilot AI requested a review from Apollon77 September 14, 2025 15:55
Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed @GermanBluefox I do not really like the name, of the field because e.g. "previousRepoReadTime" or such would be more descriptive .. but thats in the end nits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: Typing for new field in repository
3 participants