-
-
Notifications
You must be signed in to change notification settings - Fork 57
Fix confusing global dependency error message to be more actionable #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Changed "Adapter dependency not fulfilled on any host" to "Global adapter dependency not fulfilled" to make the error message clearer and less confusing. The word "any" in the original message suggested the dependency only needed to be on one host, when in fact global dependencies require all instances to satisfy the version requirement. Co-authored-by: Apollon77 <[email protected]>
Changed from "Global adapter dependency not fulfilled" to "Adapter dependency not fulfilled on all hosts where adapter is installed" to provide clearer guidance to users about what they need to check in multihost scenarios. Based on feedback from @Apollon77, the message now specifically tells users to check all hosts where the adapter is installed, which is the actual requirement for global dependencies. Co-authored-by: Apollon77 <[email protected]>
lgtm |
I still find this message confusing, if the dependency eg ist not installed at all |
The message will not be displayed if the adapter is not installed at all at a slave. |
Will be displayed whenever global dep ist not fulfilled, could be not installed at all but could also be wrong version on some host.. |
This message will not be displayed if i.e. admin 7.0.0 is required,admin 7.x.x is installed on master buet admin is NOT installed on slave. Message will be displayed if admin 7.x.x is installed on master and admin 6.x.x is installed on slave. This behavior is desired and ok. Onle the current message that admin dependency is not fullfilled on ANY host is wrong. In the second example dependency is fullfuöled on ANY host (master) but not on ALL host ( the slave) |
And it is displayed if no admin is installed at all and then it becomes a weird message |
OK - I see Maybe we need two diffrent messages
|
The error message for global adapter dependencies was confusing and not actionable for users. When an adapter has a global dependency that is not satisfied, the controller would show:
The phrase "on any host" was misleading and didn't guide users on what to check. For global dependencies, all instances of the adapter across all hosts must satisfy the version requirement.
This change updates the error message to be clearer and more actionable:
Example Scenario
An adapter requires
admin >= 7.4.10
as a global dependency, but the system hasadmin 7.2.6
installed on a slave host while the master hasadmin 7.6.3
.Before:
After:
Benefits
The change is minimal and surgical - only the error message text was modified without affecting any logic.
Fixes #3037.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.