Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 31, 2025

The error message for global adapter dependencies was confusing and not actionable for users. When an adapter has a global dependency that is not satisfied, the controller would show:

Adapter dependency not fulfilled on any host: required adapter "admin" has wrong version...

The phrase "on any host" was misleading and didn't guide users on what to check. For global dependencies, all instances of the adapter across all hosts must satisfy the version requirement.

This change updates the error message to be clearer and more actionable:

Adapter dependency not fulfilled on all hosts where adapter is installed: required adapter "admin" has wrong version...

Example Scenario

An adapter requires admin >= 7.4.10 as a global dependency, but the system has admin 7.2.6 installed on a slave host while the master has admin 7.6.3.

Before:

startInstance system.adapter.kecontact.0 Adapter dependency not fulfilled on any host: required adapter "admin" has wrong version. Installed "7.2.6", required ">=7.4.10"!

After:

startInstance system.adapter.kecontact.0 Adapter dependency not fulfilled on all hosts where adapter is installed: required adapter "admin" has wrong version. Installed "7.2.6", required ">=7.4.10"!

Benefits

  • Provides specific guidance on what users need to check in multihost scenarios
  • Clearly indicates that ALL hosts where the adapter is installed must meet the version requirement
  • Helps users understand they need to check slave hosts, not just the master
  • Addresses the common forum question "Why can't I install this adapter when I have the right version?" in multihost setups

The change is minimal and surgical - only the error message text was modified without affecting any logic.

Fixes #3037.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changed "Adapter dependency not fulfilled on any host" to "Global adapter dependency not fulfilled" to make the error message clearer and less confusing. The word "any" in the original message suggested the dependency only needed to be on one host, when in fact global dependencies require all instances to satisfy the version requirement.

Co-authored-by: Apollon77 <[email protected]>
@Copilot Copilot AI changed the title [WIP] [bug]: Texting " dependency not fulfilled on any host" Fix confusing global dependency error message Aug 31, 2025
@Copilot Copilot AI requested a review from Apollon77 August 31, 2025 12:30
Copilot finished work on behalf of Apollon77 August 31, 2025 12:30
Changed from "Global adapter dependency not fulfilled" to "Adapter dependency not fulfilled on all hosts where adapter is installed" to provide clearer guidance to users about what they need to check in multihost scenarios.

Based on feedback from @Apollon77, the message now specifically tells users to check all hosts where the adapter is installed, which is the actual requirement for global dependencies.

Co-authored-by: Apollon77 <[email protected]>
@Copilot Copilot AI changed the title Fix confusing global dependency error message Fix confusing global dependency error message to be more actionable Aug 31, 2025
Copilot finished work on behalf of Apollon77 August 31, 2025 12:38
@Copilot Copilot AI requested a review from Apollon77 August 31, 2025 12:38
@Apollon77 Apollon77 marked this pull request as ready for review August 31, 2025 12:42
@mcm1957
Copy link
Contributor

mcm1957 commented Aug 31, 2025

lgtm

@foxriver76
Copy link
Collaborator

I still find this message confusing, if the dependency eg ist not installed at all

@mcm1957
Copy link
Contributor

mcm1957 commented Aug 31, 2025

The message will not be displayed if the adapter is not installed at all at a slave.

@foxriver76
Copy link
Collaborator

Will be displayed whenever global dep ist not fulfilled, could be not installed at all but could also be wrong version on some host..

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 1, 2025

This message will not be displayed if i.e. admin 7.0.0 is required,admin 7.x.x is installed on master buet admin is NOT installed on slave.

Message will be displayed if admin 7.x.x is installed on master and admin 6.x.x is installed on slave.

This behavior is desired and ok.

Onle the current message that admin dependency is not fullfilled on ANY host is wrong. In the second example dependency is fullfuöled on ANY host (master) but not on ALL host ( the slave)

@foxriver76
Copy link
Collaborator

And it is displayed if no admin is installed at all and then it becomes a weird message

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 1, 2025

OK - I see
Any better texting suggestion?

Maybe we need two diffrent messages

  • one if the adapter (admin) is not installed at all on any host
  • and a second if admin ist installed but with an incorrect version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Texting " dependency not fulfilled on any host"
4 participants