[TYPES] Added bundlerType to VisWidget #3063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new bundlerType field to the visWidgets schema for typing support.
- Introduces
bundlerTypewith a description,stringtype, and anenumof allowed values. - Restricts bundler type to
"module"per current support.
Comments suppressed due to low confidence (1)
schemas/io-package.json:1542
- [nitpick] The description phrasing ‘let it empty’ is unclear and grammatically awkward. Consider changing it to ‘leave it empty’ and clarify whether the property should be omitted or set to an empty string for JavaScript widgets.
"description": "Bundler type of the widget set. Currently only 'module' is supported, if the widget was written with TypeScript. If the widget was written with JavaScript, let it empty.",
| "description": "Bundler type of the widget set. Currently only 'module' is supported, if the widget was written with TypeScript. If the widget was written with JavaScript, let it empty.", | ||
| "type": "string", | ||
| "enum": [ | ||
| "module" |
There was a problem hiding this comment.
The enum currently only allows "module", but the description implies JavaScript widgets should use an empty value. You may need to include an empty string in the enum (e.g., ["module", ""]) or clarify that omitting the property indicates JavaScript widgets.
Suggested change
| "module" | |
| "module", | |
| "" |
Copilot uses AI. Check for mistakes.
Apollon77
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typing for visWidgets