feat: display model storage size #7877
Open
+215
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api
python
keturn
force-pushed
the
feat/show_model_size
branch
2 times, most recently
from
5ebccb3 to
b81e0f5
Compare
keturn
force-pushed
the
feat/show_model_size
branch
from
1075fbd to
8cd6940
Compare
keturn
commented
Apr 4, 2025
invokeai/frontend/web/src/features/modelManagerV2/subpanels/ModelManagerPanel/ModelListItem.tsx
Outdated
Show resolved
Hide resolved
keturn
requested review from
psychedelicious,
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
brandonrising and
jazzhaiku
as code owners
|
Okay, this technically works now. Do we want to disambiguate "size"? Call it "storage size" or "disk size" or something to distinguish from RAM size or pixel size? |
|
File Size? Model Size? I think it probably is clearest 🤔 |
keturn
force-pushed
the
feat/show_model_size
branch
from
3c00786 to
4ecc699
Compare
added 8 commits
April 9, 2025 17:20
to disambiguate from RAM size or pixel size
psychedelicious
force-pushed
the
feat/show_model_size
branch
from
29bac7d to
5a31815
Compare
psychedelicious
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How much disk space is each model taking up? Inquiring minds want to know.
Filesystem management tools could tell us this too, but if users go mucking around in the models filesystem and delete things there (outside of the app) then the database no longer reflects reality.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1357425455816507452
QA Instructions
Merge Plan
There is a database migration!
Checklist
What's Newcopy (if doing a release after this PR)