[Cleanup] Filtering Active Payment Terms#3171
Open
Civolilah wants to merge 2 commits into
Open
Conversation
Member
|
this is better, but then it does lead to issues like this: 
most likely this is just a compromise for the given issue we are dealing with here thou.. |
Collaborator
Author
@turbo124 Okay, I understand the issue of duplicating payment terms with the same number of days. I have made a solution. Let me know your thoughts. |
Member
|
@Civolilah this reverts everything back to the precommit experience here. For example, if I have a client with 30 day payment terms. Then Archive the 30 day option. The clients option never appears in the selector. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@beganovich @turbo124 The PR includes filtering active payment terms instead of displaying all of them for selectors. Let me know your thoughts.