Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Replace $timeout with $interval#45

Open
joetinoco wants to merge 9 commits intoinvertase:masterfrom
joetinoco:master
Open

Replace $timeout with $interval#45
joetinoco wants to merge 9 commits intoinvertase:masterfrom
joetinoco:master

Conversation

@joetinoco
Copy link

When testing with Protractor, the $timeout used to clear toasts blocks Angular until the toast goes away, and that makes it impossible to assert the toast contents, for example.

The solution, as discussed in this Protractor issue, is simply to use $interval instead of $timeout - that's what is included in this pull request.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Ehesp
❌ Joe Tinoco


Joe Tinoco seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants