SYNCHRONIZE will fall into an infinite loop #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYNCHRONIZE will fall into an infinite loop
lambda expression in for loop causes all the funcs in queue are the same
|
Any news on this merge? |
|
Looks reasonable to me, but I'm not working on this project, and will not have time to test it in my spare time. |
|
@lucasfcardozo are you intended to approve this merge request? |
|
A similar PR #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firstly, SYNCHRONIZE will fall into an infinite loop without self.itemq.task_done(); secondly, lambda expression in for loop causes functions in queue point to the same fuction because of python late binding.