-
Notifications
You must be signed in to change notification settings - Fork 543
Create rmd.yml #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create rmd.yml #50
Conversation
Convert all notebooks into rmd files and publish them on a separate branch
The generated rmd files can be seen here: https://github.com/tschm/ISLP_labs/tree/rmd-files |
So, the idea is to run this action on a commit or tag and have these automatically generated? That seems fine, then we can leave a link in the README.md to this branch? This makes sense as it will really make the .ipynb the single source as opposed to having both in the repo. I imagine most people in the course are simply going to use .ipynb |
There is also a new release job. Go to Actions => Bump version and publish (on left). It will introduce a new tag and a release. |
Yes, I saw that.
Thanks for this work on the actions! Haven't tried them yet, but this is great.
…________________________________
From: Thomas Schmelzer ***@***.***>
Sent: Wednesday, April 9, 2025 8:47 PM
To: intro-stat-learning/ISLP_labs ***@***.***>
Cc: Jonathan Taylor ***@***.***>; Comment ***@***.***>
Subject: Re: [intro-stat-learning/ISLP_labs] Create rmd.yml (PR #50)
There is also a new release job. Go to
Actions => Bump version and publish (on left).
It will introduce a new tag and a release.
—
Reply to this email directly, view it on GitHub<#50 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACTM234SCFYTGM32KY6FU32YXSW7AVCNFSM6AAAAAB2NYQBYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJRGQ3TMNBWG4>.
You are receiving this because you commented.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/2046079?s=20&v=4]tschm left a comment (intro-stat-learning/ISLP_labs#50)<#50 (comment)>
There is also a new release job. Go to
Actions => Bump version and publish (on left).
It will introduce a new tag and a release.
—
Reply to this email directly, view it on GitHub<#50 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACTM234SCFYTGM32KY6FU32YXSW7AVCNFSM6AAAAAB2NYQBYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJRGQ3TMNBWG4>.
You are receiving this because you commented.Message ID: ***@***.***>
|
@jonathan-taylor So, I have never worked with Rmd files. I assume you can run them using RStudio? However, the files (e.g. auto.csv, etc.) are not copied with them to the new branch. I think it would be good if we put all files needed by the notebooks into a folder data and copy this folder also for the “rmd-files” branch? |
Yes, this makes sense. There are a handful of files needed for the notebooks to run to completion.
At least
*
Auto.{csv,data}
*
book_images/*
*
imagenet_class_index.json
Yes, they can be opened in RStudio. I also find it handy to have a text notebook around as it's easier to edit and read than .ipynb.
…________________________________
From: Thomas Schmelzer ***@***.***>
Sent: Thursday, April 10, 2025 9:07 PM
To: intro-stat-learning/ISLP_labs ***@***.***>
Cc: Jonathan Taylor ***@***.***>; Mention ***@***.***>
Subject: Re: [intro-stat-learning/ISLP_labs] Create rmd.yml (PR #50)
@jonathan-taylor<https://github.com/jonathan-taylor> So, I have never worked with Rmd files. I assume you can run them using RStudio? However, the files (e.g. auto.csv, etc.) are not copied with them to the new branch. I think it would be good if we put all files needed by the notebooks into a folder data and copy this folder also for the “rmd-files” branch?
—
Reply to this email directly, view it on GitHub<#50 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACTM26KNDLT7E4Q2FEM64L2Y45YZAVCNFSM6AAAAAB2NYQBYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJVG44DGMZUGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/2046079?s=20&v=4]tschm left a comment (intro-stat-learning/ISLP_labs#50)<#50 (comment)>
@jonathan-taylor<https://github.com/jonathan-taylor> So, I have never worked with Rmd files. I assume you can run them using RStudio? However, the files (e.g. auto.csv, etc.) are not copied with them to the new branch. I think it would be good if we put all files needed by the notebooks into a folder data and copy this folder also for the “rmd-files” branch?
—
Reply to this email directly, view it on GitHub<#50 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AACTM26KNDLT7E4Q2FEM64L2Y45YZAVCNFSM6AAAAAB2NYQBYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJVG44DGMZUGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@jonathan-taylor I am introducing a “data” folder and copy it over during ci/cd. Currently the tests are running. |
# Conflicts: # Ch02-statlearn-lab.ipynb # Ch03-linreg-lab.Rmd # Ch04-classification-lab.Rmd # Ch05-resample-lab.Rmd # Ch06-varselect-lab.Rmd # Ch07-nonlin-lab.Rmd # Ch08-baggboost-lab.Rmd # Ch09-svm-lab.Rmd # Ch10-deeplearning-lab.Rmd # Ch10-deeplearning-lab.ipynb # Ch11-surv-lab.Rmd # Ch12-unsup-lab.Rmd # Ch13-multiple-lab.Rmd
I have added an example how I think about using the ipynb files as templates. I have added the file ChXX (you can remove it later) with {{ author }} somewhere in a Markdown cell. I then have two different config files. One for rmd files and one for LaTeX files. In render.py I use Jinja to inject the desired values. Please check the rmd files branch in my fork of your repo to see the results... Please try to merge #61 and #65 |
Convert all notebooks into rmd files and publish them on a separate branch. Do not remove the rmd files from the main branch yet.
PR Order