Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nuxt I18n type inference #1628

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

BobbieGoede
Copy link
Member

Not sure why this change fixes the type inference issue 😅 Also curious why this issue did not show up sooner..

@kazupon kazupon added the Type: Bug Bug or Bug fixes label Nov 3, 2023
@BobbieGoede BobbieGoede force-pushed the fix/nuxt-i18n-type-inference branch from 1cd5514 to 295d50d Compare November 3, 2023 06:06
@BobbieGoede
Copy link
Member Author

I wonder why this is not an issue for vuejs/router, the types have the same setup as here, see https://github.com/vuejs/router/blob/b6d12edacbae531c45a4a946d5f20fc82264af52/packages/router/src/globalExtensions.ts#L71.. 🤔

@kazupon kazupon merged commit 9302664 into intlify:master Nov 4, 2023
18 checks passed
@rchl
Copy link

rchl commented Nov 4, 2023

I wonder if there will still be an issue because you are declaring a declare module '@vue/runtime-core' but not referencing @vue/runtime-core first.

@metkm
Copy link

metkm commented Nov 4, 2023

Can we also get a release for https://github.com/nuxt-modules/i18n with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n breaks Nuxt Auto-Import functionality!
4 participants