fix: locale polluted by cross request #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kazupon Could u take some time to review this PR? Thx a lot! |
kazupon
added
bug
kazupon
reviewed
Nov 19, 2024
src/index.ts
Outdated
| @@ -27,6 +33,7 @@ import type { | |||
| declare module 'h3' { | |||
| interface H3EventContext { | |||
| i18n?: CoreContext | |||
| i18nLocale?: LocaleDetector | |||
There was a problem hiding this comment.
i18nLocale is for internal use, so we don't want to expose it to H3EventContext. Please don't export it. 🙏
There was a problem hiding this comment.
The LocaleDetector getter needs to bind to event scope. Maybe rename it to _i18nLocale, which means that it's private. 🤔
There was a problem hiding this comment.
Maybe rename it to _i18nLocale, which means that it's private. 🤔
Look good to me!
You can change to it!
kazupon
requested changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when there are two concurrent requests with two different locales, the locale of the first locale would be overridden by the second request because they share the same i18n context but in different h3 event context. This PR fix it by binding the locale of h3 event to
translatefunction.Before
After
Test pass ✅
Linked Issues
Additional context