Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add devcontainer.json #26

Merged
merged 1 commit into from
Dec 26, 2023
Merged

feat: add devcontainer.json #26

merged 1 commit into from
Dec 26, 2023

Conversation

DavidDeSloovere
Copy link
Contributor

Description

This allows developers on Windows to open the project in VS Code using a Docker container that runs Debian, including Node, Deno, Bun.

vscode ➜ /workspaces/h3 $ bun --version
1.0.16
vscode ➜ /workspaces/h3 $ node --version
v20.10.0
vscode ➜ /workspaces/h3 $ deno --version
deno 1.38.5 (release, x86_64-unknown-linux-gnu)
v8 12.0.267.1
typescript 5.2.2

Is able to run the tests without issues using npm run test

Linked Issues

#25

Additional context

All files where 'changed' in git, because I first opened in Windows before creating the devcontainer. Adding extra config to .gitattributes to specify line endings.

@kazupon kazupon added the feature Includes new features label Dec 26, 2023
kazupon
kazupon approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!
LGTM!

@kazupon kazupon merged commit 6c67754 into intlify:main Dec 26, 2023
4 checks passed
@kazupon kazupon mentioned this pull request Dec 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
feature Includes new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidDeSloovere @kazupon