add initial version of DB schema #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmeecer
added
enhancement
added 2 commits
April 27, 2018 20:39
zmeecer
commented
May 9, 2018
| ```sql | ||
| CREATE TABLE person ( | ||
| id SERIAL PRIMARY KEY, | ||
| login VARCHAR(20) NOT NULL, |
Member
Author
There was a problem hiding this comment.
not sure about using login, name and email together
| id SERIAL PRIMARY KEY, | ||
| login VARCHAR(20) NOT NULL, | ||
| name VARCHAR(35) NOT NULL, | ||
| email VARCHAR(35) UNIQUE NOT NULL, |
Member
Author
There was a problem hiding this comment.
let's use 64 length for login, name, and email
| avatar_url VARCHAR | ||
| ); | ||
|
|
||
| CREATE TABLE organization ( |
Member
Author
There was a problem hiding this comment.
looks pretty similar to person table
| CREATE TABLE membership ( | ||
| organization_id INT REFERENCES organization(id), | ||
| person_id INT REFERENCES person(id), | ||
| role VARCHAR CHECK (role IN ('owner', 'member')), |
Member
There was a problem hiding this comment.
admin sounds reasonable and better
| id SERIAL PRIMARY KEY, | ||
| title VARCHAR(30) NOT NULL, | ||
| description VARCHAR NOT NULL, | ||
| location VARCHAR(50), |
Member
Author
There was a problem hiding this comment.
location can be a list of available location
Member
There was a problem hiding this comment.
it can be, but for now it will be simple text, that user type by hands
| CONSTRAINT applicant_id PRIMARY KEY (vacancy_id, person_id) | ||
| ); | ||
|
|
||
| CREATE TABLE test ( |
ok2ju
requested changes
May 21, 2018
Member
ok2ju
left a comment
ok2ju
left a comment
There was a problem hiding this comment.
there are some comments at this MR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in progress