Repository navigation
[raft] Serve the admin API for the membership of Raft groups - #1903
Open
MariemBaccari wants to merge 2 commits into
Open
MariemBaccari wants to merge 2 commits into
MariemBaccari wants to merge 2 commits into
Conversation
MariemBaccari
force-pushed
the
serve_admin
branch
from
November 4, 2026 07:58
95d6dc2 to
5d7825f
Compare
the-glu
reviewed
Nov 4, 2026
| err = stacktrace.Propagate(err, "Could not add node %d to the %s raft group", nodeID, req.GroupName) | ||
| errResp := &restapi.ErrorResponse{Message: dsserr.Handle(ctx, err)} | ||
| switch stacktrace.GetCode(err) { | ||
| // Unavailable: this node is not a member of the group, the request must be sent to a member. |
Member
There was a problem hiding this comment.
nit: that not in sync with description of 400 in the interface, the case should probably be added no?
Contributor
Author
There was a problem hiding this comment.
I just updated it to sync it with the latest admin.yaml.
MariemBaccari
force-pushed
the
serve_admin
branch
from
November 4, 2026 12:09
5d7825f to
d8e0e3f
Compare
MariemBaccari
force-pushed
the
serve_admin
branch
from
November 4, 2026 14:56
d8e0e3f to
742077f
Compare
MariemBaccari
force-pushed
the
serve_admin
branch
from
November 5, 2026 13:20
742077f to
06b832e
Compare
the-glu
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #1719 and closes #1790. It depends on #1902 so only the last commit should be reviewed.
It implements serving the admin API on a unix socket and managing the raft groups via
consensus.