Repository navigation
[helm] Allow configuration of the namespace - #1868
Merged
Merged
Conversation
Contributor
|
Can you please confirm this was tested ? |
Member
Author
I tested partially and it was looking fine, just to be sure I did a full test from scratch and it's ok (in the usual aws-gke tanka-helm deployment). |
Member
Author
(I opened the follow-up PRs, this has been tested with #1879) |
barroco
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #1859 to normalize helm/tanka/terraform deployments.
This add support for namespace in helm.
(No update on terraform side yet)