Add command for showing all class members, including inherited #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1623. Adds a class icon button to the editor title bar when the editor contains a class. When clicked, a QuickPick appears with all members of that class, including inherited ones. Clicking on a member shows it in the editor.
I initially tried to implement this as a tree view, which prompted me to make some architectural improvements. I kept those in because I think they are worth including. I consolidated three three
onDidChangeActiveTextEditorhandlers to a single one, and I added the existing tree views to the array of disposables so their resources get cleaned up properly.