[PB-5897] Fix participant count and zombies on reload#213
[PB-5897] Fix participant count and zombies on reload#213TamaraFinogina wants to merge 14 commits intomainfrom
Conversation
TamaraFinogina
changed the title
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
meet-web | b02c8a8 | Commit Preview URL Branch Preview URL |
May 08 2026, 09:13 AM |
TamaraFinogina
changed the title
|
|
||
| fetch(`${MEET_API_URL}/call/${callId}/users/leave`, { | ||
| method: "POST", | ||
| keepalive: true, |
There was a problem hiding this comment.
waiting for what we discussed about handling this with a keepalive so that the browser doesn't close the request when the page is refreshed :)
There was a problem hiding this comment.
Done, switched to sdk 1.15.14, which has post with keep alive option
| dispatch(hangup(true, roomId, i18next.t(titlekey) || reason)); | ||
| // new jitsi change, test aht does notifyOnConferenceDestruction | ||
| // dispatch(hangup(true, i18next.t(titlekey) || reason, notifyOnConferenceDestruction)); | ||
| dispatch(hangup(true, roomId, i18next.t(titlekey) || reason, notifyOnConferenceDestruction)); |
There was a problem hiding this comment.
what does notifyOnConferenceDestruction do?
There was a problem hiding this comment.
// Whether to notify when the conference is terminated because it was destroyed.
// notifyOnConferenceDestruction: true,
According to Jitsi, it's a question of whether to send a notification or not. I'll activate it just in case. So far, Jitsi's signals are blocked, but maybe it will start working after we permit them
| } | ||
| if (options.conferenceRequestUrl) { | ||
| options.conferenceRequestUrl = appendURLParam(options.conferenceRequestUrl, "room", roomName ?? ""); | ||
| options.conferenceRequestUrl = ConfigService.instance.isDevelopment() |
| connection.addFeature(DISCO_JIBRI_FEATURE); | ||
| } | ||
|
|
||
| case CONNECTION_DISCONNECTED: { |
There was a problem hiding this comment.
[PB-5897] use session storage for anonymous ID
[_] remove old login code
|
Deploying meet-web with
|
| Latest commit: | b02c8a8 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17046065.meet-web.pages.dev |
| Updated (Europe/Madrid): | 8/5/2026, 11:12:46 |
2 participants
Description
If the participant does a page reload, the count of users inside the room becomes incorrect (shows more users than the actual participants inside the room) because the server didn't receive the leaveCall request. Also, there were zombies because
beforeunloadwas stopping normal Jitsi disconnect events and never re-sending them afterwards.Ideally, front and server need to do ping-pong, keepalive, or similar, so front doesn't have to notify the server.
As a temporary fix, the browser will manually send a leaveCall request upon pagehide event. Also, leaving page confirmation was removed.
Checklist
How Has This Been Tested?
Local QA