[PB-1967]: feat/download attachments#56
Merged
Merged
Conversation
jzunigax2
reviewed
Jun 3, 2026
Comment on lines
+303
to
+326
| const safeName = sanitizeFilename(name); | ||
| const safeType = sanitizeMimeType(type); | ||
|
|
||
| const mail = await this.emailService.getEmail(email, _id); | ||
| if (!mail) throw new NotFoundException('Email not found'); | ||
|
|
||
| const attachment = mail.attachments.find((a) => a.blobId === blobId); | ||
| if (!attachment) throw new NotFoundException('Attachment not found'); | ||
|
|
||
| const result = await this.emailService.downloadAttachment({ | ||
| userEmail: email, | ||
| blobId, | ||
| name: safeName, | ||
| type: safeType ?? undefined, | ||
| }); | ||
|
|
||
| const resolvedType = safeType ?? result.contentType; | ||
|
|
||
| res.setHeader('Content-Type', resolvedType); | ||
| res.setHeader('Content-Disposition', buildContentDisposition(safeName)); | ||
| if (result.contentLength !== undefined) | ||
| res.setHeader('Content-Length', result.contentLength); | ||
|
|
||
| return new StreamableFile(result.stream); |
Contributor
There was a problem hiding this comment.
nitpick controller logic should stay thin with no business logic. the res.setHeader stuff does belong here
| const namePart = encodeURIComponent(name ?? 'attachment'); | ||
| const acceptQuery = type ? `?accept=${encodeURIComponent(type)}` : ''; | ||
|
|
||
| const { statusCode, headers, body } = await this.uploadClient.request({ |
Contributor
There was a problem hiding this comment.
maybe rename uploadClient, to blob client or similar? sounds confusing
|
jzunigax2
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to download an attachment given its email.
We will need to validate, if we want to, if the attachment belongs to a specific email. To do so, I need the PR that returns the mail attachments.