Remove deadcode#132
Merged
Merged
Conversation
sg-gs
approved these changes
May 14, 2026
Member
sg-gs
left a comment
There was a problem hiding this comment.
Bump the version on the package.json
larryrider
reviewed
May 14, 2026
| uploadedBytes: number | null, | ||
| totalBytes: number | null, | ||
| ) => void; | ||
| export type EncryptProgressCallback = (progress: number) => void; |
Contributor
There was a problem hiding this comment.
this type is being used at cli, so bump the version using minor instead of patch. Just in case any of the other removed exports are being used in other projects
larryrider
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR implements
knipso we can know which code is used and which not. I've also set theclias entry so it doesn't consider it as deadcode.First, we need to find all code that is still used, for that I search
org:internxt from '@internxt/inxt-jsin github. After that I found the following repos using it:For the relevant ones I search what imports are using from
inxt-js: