[PB-6433]: feature/design for request access to shared item flow#1966
Merged
Conversation
Deploying drive-web with
|
| Latest commit: |
e8aef45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1dc70f17.drive-web.pages.dev |
| Branch Preview URL: | https://feature-design-for-request-a.drive-web.pages.dev |
CandelR
reviewed
May 25, 2026
| onChangeAccount: () => void; | ||
| } | ||
|
|
||
| const TEXTAREA_MAX_LENGTH = 1000; |
Collaborator
There was a problem hiding this comment.
this constant is not used in the component
| }, | ||
| "accessRequests": { | ||
| "pending": "" | ||
| }, |
Collaborator
There was a problem hiding this comment.
This translation is used? I don't find it. Also this is the only translation file that it has it
| return ( | ||
| <div className="flex flex-col w-full"> | ||
| {accessRequestList.map((request, index) => ( | ||
| <RequestCheap key={index} {...request} /> |
Collaborator
There was a problem hiding this comment.
Have some sonar cloud warnings
Contributor
Author
There was a problem hiding this comment.
Yes. The design/components are added but not used (so we do not break the current flow for now). This way, we just need to add the logic and this design later and that's it.
They will be fixed later when completing the task.
CandelR
approved these changes
May 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementing the necessary components and modifying the existing ones to allow the users to request access to a restricted shared items. The new components for this flow has been added but they are been commented so it does not infer with the correct flow until we add the logic.
Maybe the components are modified in the future, but these are the initial/basic ones.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes