[PB-6824]:feat/new dynamic login desgin#1962
Conversation
Deploying drive-web with
|
| Latest commit: |
171829b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fea9a5b1.drive-web.pages.dev |
| Branch Preview URL: | https://feat-new-login-design.drive-web.pages.dev |
| <div | ||
| className={`relative flex h-full w-full flex-col dark:bg-[#0A0F1C] ${props.displayIframe ? '' : 'overflow-hidden'}`} | ||
| > | ||
| <style>{` | ||
| @keyframes orbTL { | ||
| 0%, 100% { transform: translate(0, 0) rotate(-164.506deg); } |
There was a problem hiding this comment.
Move all this animation into a separate component, that will make it easier to reuse and maintain.
I can’t see this new background on the sign up screen.
Do we only want it on the login screen? It looks a bit odd.
Have you checked mobile login and sign up screens?
There was a problem hiding this comment.
Moved the animation, also checked with design if we need to update the Sign In and yes!
| buttonDataCy="loginButton" | ||
| variant="primary" | ||
| disabled={isLoggingIn} | ||
| className="disabled:!bg-primary" |
There was a problem hiding this comment.
remove disabled while logging is a specificaction of the task?
There was a problem hiding this comment.
No the idea was to not having in gray, updated
|
CandelR
left a comment
CandelR
left a comment
There was a problem hiding this comment.
Remain modify the login and signup forms to both follow the same structure and review the Playwright tests that are failing :)
|
In QA, we've found a couple more pages where we need to add a background |
Okay, just request us review when it’s ready :) |
|
3 participants
Description
This PR introduces a new login design, with the following key changes:
Everything has been implemented in both light and dark modes
The task dont say anything about the "new" page
Related Issues
Related Pull Requests
Checklist
Testing Process
Just been in login and check that everything is working as expected
Additional Notes