[MKT-828]:feat/Unify analytics tracking around explicit payment intents#1938
Open
jaaaaavier wants to merge 12 commits into
Open
[MKT-828]:feat/Unify analytics tracking around explicit payment intents#1938jaaaaavier wants to merge 12 commits into
jaaaaavier wants to merge 12 commits into
Conversation
Deploying drive-web with
|
| Latest commit: |
d7f5f69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54663215.drive-web.pages.dev |
| Branch Preview URL: | https://feat-impact-tracking-service.drive-web.pages.dev |
xabg2
reviewed
May 11, 2026
| describe('trackSignUp', () => { | ||
| describe('gtag tracking', () => { | ||
| it('should send User Signup event to gtag', async () => { | ||
| it('When trackSignUp is called, then it sends User Signup event to gtag', async () => { |
Contributor
There was a problem hiding this comment.
Avoid using technical descriptions. Describe what it does, not how it does (calling methods and this things), Same for the other descriptions
xabg2
previously approved these changes
May 11, 2026
….com/internxt/drive-web into feat/impact-tracking-services-ipdaye
|
Contributor
Author
|
We've added a new feature to this PR: the irclickid track. This will help us improve sales tracking and attribution. It's a parameter included in the URL generated by Impact that may help us resolve some attribution issues we're currently facing. |
xabg2
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unified Tracking Identifier: Removed all
subscriptionIdcaching and extraction from the checkout tracking layeruseUserPayment.ts,ga.service.ts,impact.service.ts. Analytics now exclusively read and pipepaymentIntentIdfor both standalone purchases and recurring subscriptions.Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes