[_] test_plainName#972
Open
TamaraFinogina wants to merge 5 commits into
Open
Conversation
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
|
|
This PR is stale because it has been open for more than 15 days with no activity. |
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
apsantiso
force-pushed
the
test_plainName
branch
from
7efe9da to
e6df03d
Compare
|
jzunigax2
approved these changes
Apr 15, 2026
sg-gs
reviewed
Apr 15, 2026
Member
sg-gs
left a comment
sg-gs
left a comment
There was a problem hiding this comment.
Shouldn't we make plainName NOT NULL first @apsantiso ?
Collaborator
We can't, there are some files without name. For example, macOS client uploads . DS_Store constanly |
|
This PR is stale because it has been open for more than 15 days with no activity. |
apsantiso
added
the
blocked
Collaborator
|
@TamaraFinogina marked this as "blocked" so it does not get closed automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to return plainName instead of name to see if we can drop legacy name encryption/decryption.