[_]: bugfix/Fix video thumbnail generation for video files#448
Open
CandelR wants to merge 1 commit intofeature/PB-6372-pull-to-refreshfrom
Open
[_]: bugfix/Fix video thumbnail generation for video files#448CandelR wants to merge 1 commit intofeature/PB-6372-pull-to-refreshfrom
CandelR wants to merge 1 commit intofeature/PB-6372-pull-to-refreshfrom
Conversation
|
TamaraFinogina
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video thumbnails were never generated during photo backup on iOS.
react-native-create-thumbnailnative module received afile://URI but then wrapped it again with[NSURL fileURLWithPath:], producing an invalid double-scheme URL (file:///file:///path/to/video.mov).AVAsset silently failed to load it, the promise rejected, and the silent
catch {}inuploadThumbnailForAssetswallowed the error, so no video ever got a thumbnail uploaded.Fix
Added
else if ([url_ hasPrefix:@"file://"])branch to thevidURLconstruction inCreateThumbnail.m, mirroring the same pattern already used for image URLs.