Feat/pb 5241 marketing notifications#383
Open
AlexisMora wants to merge 2 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
This pull request introduces the feature of recieving Marketing notifications, once the user clicks the notification it will redirect to the given url.
also Added
foldResultto the shared Result utility to make success/error handling explicit.Initially, showing notifications through main process was giving me a "SIGSEV" error and crashing the app so i have made a workaround to open them from the renderer process.
Why
Marketing notifications need to be shown as native user notifications and open their associated marketing URL when clicked.
The first main-process implementation could trigger an Electron native SIGSEGV on Linux when clicking notifications. Moving the clickable notification behavior to the renderer avoids that crash path and reuses the existing renderer notification/open-url pattern already used elsewhere in the app.