feat: Refactor device management functions to use Result type for error handling#311
Open
egalvis27 wants to merge 18 commits into
Open
feat: Refactor device management functions to use Result type for error handling#311egalvis27 wants to merge 18 commits into
egalvis27 wants to merge 18 commits into
Conversation
AlexisMora
reviewed
Apr 23, 2026
|
|
||
| const result = folder.children.map((backup) => ({ | ||
| name: backup.plainName, | ||
| pathname: '' as AbsolutePath, |
There was a problem hiding this comment.
is there any other way to infer the type without forcing it?
egalvis27
force-pushed
the
refactor/device-backend-module
branch
from
25b4f0e to
e5c8eab
Compare
|
* feat: Get Attributes operation + Electron 21 * fix: node: http
… and French locales (#301)
* feat: golang lint * feat: golang test pipeline * chore: go daemon testing * chore: testing for virtual drive module * fix: go lint workflow * fix: go lint workflow bump version * chore: lint issues in golang * fix: pr comments * fix: format
…r creation dependencies (#310)
…d improve type imports Co-authored-by: Copilot <copilot@github.com>
* feat: Implement Open and OpenDir FUSE opeartions * fix:format * fix: linting warnings * fix: simplification of fuse status transport betweeen daemon and electron * chore:tests * fix:format * chore: skip unused fuseApp class test + fix test * Fix lint warning
… services, and tests (#320)
…nge-backup-path tests; remove unused lodash import in getBackupsFromDevice
egalvis27
force-pushed
the
refactor/device-backend-module
branch
from
c7750c2 to
5a3f46a
Compare
…wline at end of JSON files
…clean up README formatting
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
A few months ago, several issues were detected around device creation. During that period, the debugging process was especially difficult because the flow concentrated too much logic in a few places, error handling was not fully consistent, and test coverage was limited in critical paths.
This refactor aims to improve the internal quality of the device module so it becomes easier to understand, maintain, and debug, while also reducing the risk of regressions in future changes.