Skip to content

[_] Small fixes#60

Merged
TamaraFinogina merged 13 commits into
optional_subject_encfrom
small_fixes
May 28, 2026
Merged

[_] Small fixes#60
TamaraFinogina merged 13 commits into
optional_subject_encfrom
small_fixes

Conversation

@TamaraFinogina
Copy link
Copy Markdown
Contributor

@TamaraFinogina TamaraFinogina commented May 28, 2026

Description

  • Remove body from all types, functions, and comments
  • Simplify errors
  • Add more tests for better coverage
  • Remove old functions from readme

Related Pull Requests

Build on top of this PR

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

unit tests

@TamaraFinogina TamaraFinogina requested a review from xabg2 May 28, 2026 09:52
@TamaraFinogina TamaraFinogina self-assigned this May 28, 2026
Comment thread src/types.ts
};

export type EmailBodyEncrypted = {
export type EmailEncrypted = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm this is only for the body. BodyEncrypted should be enough, or you can unify this type and the next one.

Copy link
Copy Markdown
Contributor Author

@TamaraFinogina TamaraFinogina May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we don't have Body as a type. It will then be Email EmailAndSubject BodyEncrypted BodyAndSubjectEncrypted

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@TamaraFinogina TamaraFinogina merged commit fcfaa96 into optional_subject_enc May 28, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants