Skip to content

[_] Remove unused or duplicated functions#43

Merged
TamaraFinogina merged 4 commits into
masterfrom
remove_duplicates
Mar 20, 2026
Merged

[_] Remove unused or duplicated functions#43
TamaraFinogina merged 4 commits into
masterfrom
remove_duplicates

Conversation

@TamaraFinogina

@TamaraFinogina TamaraFinogina commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Description

Remove duplicated functions that only differ in applying type transformations:

  1. '@noble/hashes/utils.js' is a smaller import than the same from post-quantum
  2. deriveSymmetricKeyFromTwoKeysAndContext is not used anymore
  3. I removed the HEX version from deriveKey and hash; converters are in utils, so it's a bit redundant
  4. mac and keyedHash is the same, hence redundant
  5. deriveWrappingKey is not used anymore

Related Pull Requests

Build on top of another PR: #38

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

unit tests

@TamaraFinogina TamaraFinogina self-assigned this Mar 19, 2026
@TamaraFinogina TamaraFinogina marked this pull request as ready for review March 19, 2026 13:51
@sonarqubecloud

Copy link
Copy Markdown

@TamaraFinogina TamaraFinogina changed the base branch from simplify_enc_emails to master March 20, 2026 09:47
@TamaraFinogina TamaraFinogina merged commit 1ffc6a9 into master Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants