feat(car): pin relation hsm calls #3562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
# Conflicts: # bruno/collections/Rafiki/environments/Local Playground.bru
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+331
to
+366
| app.post('/hsm/verify-pin', async function handler(ffReq, ffReply) { | ||
| const requestBody = JSON.parse(JSON.stringify(ffReq.body)) | ||
| const { pinBlock, pan, format, expectedPin, pinEncryptionKey } = requestBody | ||
|
|
||
| try { | ||
| // Validate input | ||
| if (!pinBlock || !pan || !format || !expectedPin) { | ||
| throw new Error('Missing required parameters') | ||
| } | ||
|
|
||
| if (format !== 'ISO-0' && format !== 'ISO-1') { | ||
| throw new Error('Format must be ISO-0 or ISO-1') | ||
| } | ||
|
|
||
| // Verify the PIN | ||
| const isValid = verifyPin( | ||
| pinBlock, | ||
| pan, | ||
| format, | ||
| expectedPin, | ||
| pinEncryptionKey | ||
| ) | ||
|
|
||
| logger.info(`PIN verification result: ${isValid ? 'Valid' : 'Invalid'}`) | ||
|
|
||
| ffReply.code(200).send({ | ||
| isValid, | ||
| format | ||
| }) | ||
| } catch (error) { | ||
| logger.error(`PIN verification error: ${error.message}`) | ||
| ffReply.code(400).send({ | ||
| error: error.message | ||
| }) | ||
| } | ||
| }) |
Check failure
Code scanning / CodeQL
Missing rate limiting High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 days ago
To fix the problem, we will introduce rate-limiting middleware using a well-known library such as fastify-rate-limit. This middleware will limit the number of requests that can be sent to the /hsm/verify-pin endpoint within a specified time window. The rate limiting will be applied directly to this endpoint to ensure it is protected without affecting the rest of the application.
Steps:
- Install the
fastify-rate-limitpackage. - Import the middleware into the file.
- Register the rate-limiting plugin in the Fastify instance.
- Configure rate limiting specifically for the
/hsm/verify-pinroute.
Suggested changeset
2
test/hsm-emulator/src/app.ts
| @@ -25,6 +25,10 @@ | ||
|
|
||
| export function createApp(port: number) { | ||
| const app = fastify() | ||
| app.register(require('fastify-rate-limit'), { | ||
| max: 100, // maximum number of requests | ||
| timeWindow: '1 minute' // time window for rate limiting | ||
| }) | ||
|
|
||
| app.post( | ||
| '/hsm/ase-customer/generate-zmk', | ||
| @@ -328,7 +332,9 @@ | ||
| }) | ||
|
|
||
| // Add PIN verification endpoint | ||
| app.post('/hsm/verify-pin', async function handler(ffReq, ffReply) { | ||
| app.post('/hsm/verify-pin', { | ||
| config: { rateLimit: { max: 10, timeWindow: '1 minute' } } // limit to 10 requests per minute | ||
| }, async function handler(ffReq, ffReply) { | ||
| const requestBody = JSON.parse(JSON.stringify(ffReq.body)) | ||
| const { pinBlock, pan, format, expectedPin, pinEncryptionKey } = requestBody | ||
|
|
test/hsm-emulator/package.json
Outside changed files
| @@ -14,7 +14,8 @@ | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "fastify": "^5.2.1", | ||
| "pino": "^9.6.0" | ||
| "pino": "^9.6.0", | ||
| "fastify-rate-limit": "^5.9.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^20.0.0", |
This fix introduces these dependencies
| Package | Version | Security advisories |
| fastify-rate-limit (npm) | 5.9.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #numberuser-docslabel (if necessary)