-
Notifications
You must be signed in to change notification settings - Fork 96
feat(card-service): add endpoints to initiate payment and receive payment result #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pos-card-services
Are you sure you want to change the base?
Conversation
fe6d1fb
to
5f42304
Compare
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs
|
} | ||
} | ||
|
||
async function handlePayment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider handleCreatePayment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -31,6 +31,7 @@ export const Config = { | |||
trustProxy: envBool('TRUST_PROXY', false), | |||
env: envString('NODE_ENV', 'development'), | |||
cardServicePort: envInt('CARD_SERVICE_PORT', 3007), | |||
cardPaymentTimeout: envInt('CARD_PAYMENT_TIMEOUT', 30000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing, let's also include the unit of measurement in the env var name as well
incomingPaymentUrl: uri, | ||
date: dateTime, | ||
signature: 'sig', | ||
terminalCert: 'cert', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: type error here from removing terminalCert
Changes proposed in this pull request
Context
fixes #3515
partially implements #3518
Checklist
fixes #number
user-docs
label (if necessary)