Skip to content

Conversation

@JonathanMatthey
Copy link
Contributor

Description of changes

Required

  • Used LinkOut component on external links
  • Reviewed Vale errors and made changes where appropriate
  • Ran Prettier
  • Previewed updates in Netlify
  • Received SME and/or peer approval if updates are significant
  • Included a "fixes #" comment

Conditional

  • Ensured sequence diagrams follow our style guide
  • Included code samples where appropriate
  • Updated related READMEs

@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for openpayments-preview ready!

Name Link
🔨 Latest commit 8ef1178
🔍 Latest deploy log https://app.netlify.com/projects/openpayments-preview/deploys/690ce66f52145e0008e8872a
😎 Deploy Preview https://deploy-preview-713--openpayments-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JoblersTune
Copy link
Contributor

JoblersTune commented Nov 6, 2025

Can we remove the footer from the landing page?

image

@JoblersTune
Copy link
Contributor

The Spanish translation isn't working on the component for me

@JoblersTune
Copy link
Contributor

@bosbaber even though the site is statically generated, Netlify Functions run server-side at request time, not during the build or in the browser. So surely that means they can securely store a GitHub token without ever exposing it to the client?

@JonathanMatthey
Copy link
Contributor Author

fixed:

  1. feedback now in spanish
  2. doesnt show up on splash and 404 pages

@JonathanMatthey
Copy link
Contributor Author

  • removed unused ui translations

the /developers repo used a lot of {t("nav.team")} but open-payments repo, doesnt use any. so removing for now

"starlight-openapi": "^0.19.1"
},
"devDependencies": {
"@netlify/functions": "^5.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this included as a dev dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants