-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream fuzzing fixes #715
Stream fuzzing fixes #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments and indentation nits.
} | ||
|
||
Ok(buffer_unencrypted) | ||
} | ||
} | ||
|
||
impl<'a> Iterator for FrameIterator<'a> { | ||
type Item = Frame<'a>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could even be:
type Item = Result<Frame<'a>, WhateverTheErrorIs>;
And instead of returning a FrameIterator
from StreamPacket::frames()
we could return a impl Iterator<Item = Frame<'a>>
which would be constructed from FrameIterator { ... }.map(|res| res.expect("checked at parsing time"))
.
This would however require some state in the FrameIterator
to return None
after the first Err
return value.
However this isn't something that should be handled right away, perhaps polish at the end if anything.
ab1bed9
to
d290f4b
Compare
d290f4b
to
7b01969
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, I had forgotten to approve this.
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Co-authored-by: Joonas Koivunen <[email protected]> Signed-off-by: bwty <[email protected]>
Signed-off-by: bwty <[email protected]>
Co-authored-by: Joonas Koivunen <[email protected]>
eb38cf4
to
a691723
Compare
cc: #705
Focused on fuzzing
StreamPacket
TODO: