Repository navigation
fix(tests): update unittests for common - #498
Merged
Merged
Conversation
github-actions Bot
added a commit
that referenced
this pull request
Oct 27, 2026
Automated chart versioning after merge of PR #498. This PR updates Chart.yaml versions, packages updated charts into docs/interledger, and regenerates the Helm index. Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new PVC tests rely on persistence.name/persistence.size defaults that are not defined in the chart's values, so most of those cases fail as written.
1 open issue
What changed in this PR
This PR refreshes the common library chart's unit-test suite to cover recently added behavior and bumps the two dependent charts to the library's current 0.11.0 version. It adds a new test fixture/template for PersistentVolumeClaim rendering and a new suite exercising pod/deployment fields (replica handling with explicit 0, autoscaling ownership, revisionHistoryLimit/terminationGracePeriodSeconds, and automountServiceAccountToken logic), keeping the test charts aligned with the shared library.
Changes:
- Add
pvc.yamltest template pluspvc_test.yamlcovering claim naming, storage class, access/volume modes, annotations, disabled claims, and required-field failures. - Add
deployment_pod_fields_test.yamlvalidating replica count (including explicit0), autoscaling, grace period, and service-account token mounting behavior. - Bump the
commondependency from0.10.0to0.11.0(and regenerateChart.lock) incommon-unittestsandmultideployment.
| File | Description |
|---|---|
| charts/tests/common-unittests/tests/pvc_test.yaml | New PVC rendering tests; depends on persistence defaults not present in chart values. |
| charts/tests/common-unittests/templates/pvc.yaml | New test template invoking common.pvc with .Values.persistence. |
| charts/tests/common-unittests/tests/deployment_pod_fields_test.yaml | New tests for replicas, grace period, and service-account token behavior. |
| charts/tests/common-unittests/Chart.yaml | Bumps common dependency to 0.11.0. |
| charts/tests/common-unittests/Chart.lock | Regenerated lock for common 0.11.0. |
| charts/examples/multideployment/Chart.yaml | Bumps common dependency to 0.11.0. |
| charts/examples/multideployment/Chart.lock | Regenerated lock for common 0.11.0. |
Review effort: Balanced
Comment on lines
+4
to
+5
| set: | ||
| fullnameOverride: black |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.