Repository navigation
feat(common): stateful workload support - #496
Merged
Merged
Conversation
github-actions Bot
added a commit
that referenced
this pull request
Oct 27, 2026
Automated chart versioning after merge of PR #496. This PR updates Chart.yaml versions, packages updated charts into docs/interledger, and regenerates the Helm index. Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two newly added fields (revisionHistoryLimit, terminationGracePeriodSeconds) use with and silently drop a meaningful explicit 0, contradicting the PR's own zero-preservation design, and the new PVC template lacks the unit-test coverage the common chart otherwise maintains.
3 open issues
What changed in this PR
This PR extends the shared common Helm library chart to better support stateful and batch workloads. It adds a new PersistentVolumeClaim template, surfaces pod/deployment lifecycle fields (revisionHistoryLimit, terminationGracePeriodSeconds, automountServiceAccountToken), and hardens numeric-field handling so an explicit 0 is preserved rather than collapsed to a Kubernetes default. Documentation in the chart README is expanded to cover the new fields.
Changes:
- New
common.pvctemplate rendering aPersistentVolumeClaimwith requiredname/sizevalidation and optionalaccessModes/storageClassName/volumeMode/annotations. replicaCount,backoffLimit, andttlSecondsAfterFinishednow usehasKeyso an explicit0is emitted; newrevisionHistoryLimit,terminationGracePeriodSeconds, andautomountServiceAccountTokenfields added to the pod/deployment templates.- README updated with a deployment/pod fields table and a persistent-volume-claims section.
| File | Description |
|---|---|
| charts/common/templates/_pvc.yaml | New common.pvc helper emitting a PersistentVolumeClaim with validation and optional spec fields. |
| charts/common/templates/_pod.tpl | Adds explicit automountServiceAccountToken handling and terminationGracePeriodSeconds. |
| charts/common/templates/_job.yaml | Switches backoffLimit/ttlSecondsAfterFinished to hasKey so an explicit 0 is kept; doc comment updated. |
| charts/common/templates/_deployment.yaml | Adds revisionHistoryLimit and hasKey-based replicaCount to preserve an explicit 0. |
| charts/common/README.md | Documents the new deployment/pod fields and the persistent-volume-claims helper. |
Review effort: Balanced
Comment on lines
+28
to
+29
| {{- with $deployment.revisionHistoryLimit }} | ||
| revisionHistoryLimit: {{ . }} |
Comment on lines
+32
to
+33
| {{- with $pod.terminationGracePeriodSeconds }} | ||
| terminationGracePeriodSeconds: {{ . }} |
| A GitOps controller needs its own equivalent, such as Argo CD's | ||
| `argocd.argoproj.io/sync-options: Prune=false,Delete=false`. | ||
| */}} | ||
| {{- define "common.pvc.tpl" -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.