Repository navigation
chore: bumped example and unit test common - #486
Merged
Merged
Conversation
github-actions Bot
added a commit
that referenced
this pull request
Sep 15, 2026
Automated chart versioning after merge of PR #486. This PR updates Chart.yaml versions, packages updated charts into docs/interledger, and regenerates the Helm index. Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency bumps and new helm-unittest suites are consistent with the common chart’s startupProbe implementation and do not introduce apparent correctness or schema issues.
Pull request overview
This PR updates the example and unit-test charts to consume common chart v0.9.2 and adds Helm-unittest coverage validating startupProbe rendering behavior provided by the updated common library.
Changes:
- Bump
commondependency from0.9.1to0.9.2in thecommon-unittestsandmultideploymentcharts (including updatedChart.lockdigests). - Add unit tests asserting
startupProbedefaults, supported actions (httpGet,tcpSocket,exec), and that liveness/readiness defaults remain unchanged.
File summaries
| File | Description |
|---|---|
| charts/tests/common-unittests/tests/startup_probe_test.yaml | Adds helm-unittest suite covering startupProbe behavior for the common-unittests chart. |
| charts/tests/common-unittests/Chart.yaml | Bumps common dependency version to 0.9.2. |
| charts/tests/common-unittests/Chart.lock | Updates dependency lock digest/generated timestamp for common 0.9.2. |
| charts/examples/multideployment/tests/deployment.startupProbe_test.yaml | Adds helm-unittest suite covering startupProbe behavior in the multideployment example (including sidecar/initContainer cases). |
| charts/examples/multideployment/Chart.yaml | Bumps common dependency version to 0.9.2. |
| charts/examples/multideployment/Chart.lock | Updates dependency lock digest/generated timestamp for common 0.9.2. |
Review details
- Files reviewed: 4/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.