Repository navigation
feat: startupProbe support in common - #485
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new probe action helper can silently render invalid or unintended probe YAML without enforcing that exactly one action is configured.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds startupProbe support to the shared common Helm library chart (plus expanded probe action support), enabling charts using this library to configure Kubernetes startup probes consistently alongside existing liveness/readiness probes.
Changes:
- Introduces a shared
common.probe.actionhelper to render one ofhttpGet,tcpSocket,grpc, orexecprobe actions. - Adds
common.startupProbetemplate with startup-appropriate defaults and wiresstartupProbeinto container rendering. - Documents probe usage/defaults in the common chart README and bumps the common chart version.
File summaries
| File | Description |
|---|---|
| charts/common/templates/_probe.yaml | Adds shared probe-action rendering and introduces startupProbe template/defaults. |
| charts/common/templates/_container.yaml | Renders startupProbe on containers when configured. |
| charts/common/README.md | Documents probe configuration, supported actions, and default timings. |
| charts/common/Chart.yaml | Bumps library chart version to reflect new functionality. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+17
| {{- define "common.probe.action" -}} | ||
| {{- if .httpGet }} | ||
| httpGet: {{- toYaml .httpGet | nindent 2 }} | ||
| {{- else if .tcpSocket }} | ||
| tcpSocket: {{- toYaml .tcpSocket | nindent 2 }} | ||
| {{- else if .grpc }} | ||
| grpc: {{- toYaml .grpc | nindent 2 }} | ||
| {{- else }} | ||
| exec: {{- toYaml .exec | nindent 2 }} | ||
| {{- end }} | ||
| {{- end }} |
Comment on lines
+73
to
+75
| {{- with $container.startupProbe }} | ||
| startupProbe: {{ include "common.startupProbe" (list $top .) | nindent 4 }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.