Skip to content

fix(bascinet): guard backend deployment include with enabled check - #482

Merged
bosbaber merged 1 commit into
mainfrom
stephan/20260901-bascinet-corrections
Sep 1, 2026
Merged

bosbaber merged 1 commit into
mainfrom
stephan/20260901-bascinet-corrections

Conversation

@bosbaber

@bosbaber bosbaber commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@bosbaber
bosbaber requested a review from a team as a code owner September 1, 2026 12:17
Copilot AI lite review requested due to automatic review settings September 1, 2026 12:17
@bosbaber bosbaber self-assigned this Sep 1, 2026
@bosbaber
bosbaber merged commit 56b45ec into main Sep 1, 2026
11 checks passed
@bosbaber
bosbaber deleted the stephan/20260901-bascinet-corrections branch September 1, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bascinet Helm chart so the backend Deployment is only rendered when backend.enabled is true, aligning backend behavior with the chart’s other component templates and Helm unit tests.

Changes:

  • Moves the backend.enabled guard from inside the backend.deployment helper template to wrapping the common.deployment include.
  • Ensures deployment.backend.yaml produces zero rendered documents when backend.enabled: false.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions Bot added a commit that referenced this pull request Sep 1, 2026
Automated chart versioning after merge of PR #482.
This PR updates Chart.yaml versions, packages updated charts into
docs/interledger,
and regenerates the Helm index.

Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants