[bosbaber]

No description provided.

[Copilot]

Pull request overview

Introduces a new bascinet Helm chart intended to provide a reusable, “common”-library-backed pattern for deploying up to four simple components (backend/frontend/api/worker) with consistent Deployments/ConfigMaps/Services and accompanying helm-unittest coverage.

Changes:

• Adds the bascinet chart scaffold (Chart metadata, default values, and README).
• Implements component templates for Deployments, ConfigMaps, and Services (where applicable), leveraging the shared common chart library.
• Adds helm-unittest suites covering enable/disable behavior and basic rendering expectations for services/configmaps/deployments.

Reviewed changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
charts/bascinet/values.yaml	Defines default component configuration, images, services, and envFrom wiring.
charts/bascinet/tests/service.frontend_test.yaml	Tests frontend Service creation toggled by frontend.enabled.
charts/bascinet/tests/service.backend_test.yaml	Tests backend Service created by default and absent when disabled.
charts/bascinet/tests/service.api_test.yaml	Tests api Service creation toggled by api.enabled.
charts/bascinet/tests/deployment.worker_test.yaml	Tests worker Deployment enablement and image override behavior.
charts/bascinet/tests/deployment.frontend_test.yaml	Tests frontend Deployment enablement and image override behavior.
charts/bascinet/tests/deployment.backend_test.yaml	Tests backend Deployment created by default and image override behavior.
charts/bascinet/tests/deployment.api_test.yaml	Tests api Deployment enablement and image override behavior.
charts/bascinet/tests/configMap.worker_test.yaml	Tests worker ConfigMap creation and key/value rendering when enabled.
charts/bascinet/tests/configMap.frontend_test.yaml	Tests frontend ConfigMap creation and key/value rendering when enabled.
charts/bascinet/tests/configMap.backend_test.yaml	Tests backend ConfigMap created by default and absent when disabled.
charts/bascinet/tests/configMap.api_test.yaml	Tests api ConfigMap creation and key/value rendering when enabled.
charts/bascinet/templates/service.frontend.yaml	Renders frontend Service via common.svc when enabled.
charts/bascinet/templates/service.backend.yaml	Renders backend HTTP Service via common.svc when enabled.
charts/bascinet/templates/service.api.yaml	Renders api Service via common.svc when enabled.
charts/bascinet/templates/deployment.worker.yaml	Adds config-hash annotation override and renders worker Deployment via common.deployment.
charts/bascinet/templates/deployment.frontend.yaml	Adds config-hash annotation override and renders frontend Deployment via common.deployment.
charts/bascinet/templates/deployment.backend.yaml	Adds config-hash annotation override and renders backend Deployment via common.deployment.
charts/bascinet/templates/deployment.api.yaml	Adds config-hash annotation override and renders api Deployment via common.deployment.
charts/bascinet/templates/configMap.worker.yaml	Renders worker ConfigMap from .Values.worker.config when enabled.
charts/bascinet/templates/configMap.frontend.yaml	Renders frontend ConfigMap from .Values.frontend.config when enabled.
charts/bascinet/templates/configMap.backend.yaml	Renders backend ConfigMap from .Values.backend.config when enabled.
charts/bascinet/templates/configMap.api.yaml	Renders api ConfigMap from .Values.api.config when enabled.
charts/bascinet/README.md	Documents chart purpose, components, configuration fields, and testing instructions.
charts/bascinet/Chart.yaml	Declares chart metadata and dependency on the shared common library.
charts/bascinet/Chart.lock	Pins the resolved common dependency for reproducible builds.

Suppressed comments (4)

charts/bascinet/README.md:69

• The “Configuration reference” table is also malformed due to || delimiters, which breaks rendering. Convert it to a standard pipe-delimited Markdown table.

| Field | Purpose |
|-------|---------|
| `enabled` | Turns the component's Deployment, ConfigMap, and Service on or off. |
| `name` | Name suffix for the component's resources. |
| `replicaCount` | Number of pod replicas. |

charts/bascinet/values.yaml:101

• This default envFrom.configMapRef.name hard-codes -frontend, but the ConfigMap name is derived from .Values.frontend.name. If users override frontend.name, the default envFrom reference will break; template it from the same value.

        name: "{{ include \"common.fullname\" . }}-frontend"

charts/bascinet/values.yaml:149

• This default envFrom.configMapRef.name hard-codes -api, but the ConfigMap name is derived from .Values.api.name. If users override api.name, the default envFrom reference will break; template it from the same value.

        name: "{{ include \"common.fullname\" . }}-api"

charts/bascinet/values.yaml:188

• This default envFrom.configMapRef.name hard-codes -worker, but the ConfigMap name is derived from .Values.worker.name. If users override worker.name, the default envFrom reference will break; template it from the same value.

        name: "{{ include \"common.fullname\" . }}-worker"

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.