Repository navigation
fix(common): pod will now emit volume at correct indentation - #470
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the shared common Helm library so pod volumes render at the correct YAML indentation (under the pod spec), and adds unit tests in the common-unittests chart to prevent regressions.
Changes:
- Adjust
charts/common/templates/_pod.tplsovolumes:is emitted underspec:at the correct indentation. - Add a new
helm-unittestsuite validating both user-providedvolumesandsecretProvider-generated CSI volumes render underspec.template.spec.volumes.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/common/templates/_pod.tpl | Fixes volumes: indentation so volumes are nested under the pod spec. |
| charts/tests/common-unittests/tests/volumes_test.yaml | Adds unit tests to validate pod volumes and secretProvider CSI volumes render in the correct manifest location. |
Suppressed comments (1)
charts/tests/common-unittests/tests/volumes_test.yaml:35
- This test verifies the CSI volume is rendered under
spec.template.spec.volumes, but it doesn’t assert the incorrect sibling path is absent. AddingnotExists: path: spec.template.volumesstrengthens the test to catch the original indentation regression if it reappears.
asserts:
- equal:
path: spec.template.spec.volumes[0].name
value: my-secret-provider-class
- equal:
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions Bot
added a commit
that referenced
this pull request
Sep 1, 2026
Automated chart versioning after merge of PR #470. This PR updates Chart.yaml versions, packages updated charts into docs/interledger, and regenerates the Helm index. Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.