Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversation ratings support #235

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Conversation

thewheat
Copy link
Contributor

@thewheat thewheat commented Oct 9, 2018

Why?

Current code does not support reading conversation ratings of a conversation

How?

Add extra code to support reading conversation ratings

Open to feedback for the Customer and Teammate classes. They look the same currently so maybe best to make it a single class or inherit from one?

@choran choran added the java label Oct 15, 2018
Copy link

@apassant apassant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I agree though that a parent class for Customer and Teammate would be nicer

@thewheat
Copy link
Contributor Author

I've added a Participant class in #241 which is an addition to the Customer class. Before we merge this: I think we should think if having both Participant and Customer would be the best way to go because on the API end the input and output both refer to "customer"

@choran choran merged commit 948c077 into master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants