Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About page #125

Closed
wants to merge 16 commits into from
Closed

About page #125

wants to merge 16 commits into from

Conversation

krystxf
Copy link
Member

@krystxf krystxf commented Nov 19, 2021

  • stats
  • app links

bigint
bigint requested changes Nov 19, 2021
View reviewed changes
src/pages/about.tsx Outdated Show resolved Hide resolved
src/pages/about.tsx Outdated Show resolved Hide resolved
src/pages/about.tsx Show resolved Hide resolved
src/pages/about.tsx Outdated Show resolved Hide resolved
filiptronicek
filiptronicek requested changes Nov 19, 2021
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the updates, looks great. One thing that I am curious about is why have the cursor be a pointer on the facts? I don't see why this is needed, did you want to direct the user to some more info/link?
https://github.com/interclip/interclip-next/blob/988792539e45700dccbe40a36efe3802b72a0959/src/pages/about.tsx#L118

@krystxf
Copy link
Member Author

krystxf commented Nov 19, 2021

Well I don't know really, where it should point to, it's just mistake haha

@filiptronicek
Copy link
Member

@krystofex could you please revisit this PR and take a look at @bigint's comments? Also, please, as per my comment remove the pointer cursor.

@filiptronicek
Copy link
Member

A bit sus @krystofex

image

@github-actions
Copy link

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
use-count-up ADDED - 3.0.1
use-elapsed-time ADDED - 3.0.2

@filiptronicek
Copy link
Member

@krystofex are you still going to work on this or should I close this and implement it later?

@krystxf
Copy link
Member Author

krystxf commented Jan 13, 2022

I can finish it

filiptronicek
filiptronicek approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@filiptronicek filiptronicek requested a review from bigint January 16, 2022 21:10
@filiptronicek filiptronicek enabled auto-merge (squash) January 17, 2022 10:00
@filiptronicek filiptronicek linked an issue Jan 27, 2022 that may be closed by this pull request
Add a footer #8
Open
@filiptronicek filiptronicek added the automerge To be automerged after CI passes label Feb 5, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 5, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge To be automerged after CI passes label Feb 5, 2022
@krystxf krystxf closed this Jul 16, 2023
auto-merge was automatically disabled July 16, 2023 20:18

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek approved these changes

@bigint bigint Awaiting requested review from bigint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a footer
3 participants
@krystxf @filiptronicek @bigint