Improvements #243
Open
Improvements #243
+263
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
force-pushed
the
feat/improvements
branch
from
fc3e062 to
0d097a2
Compare
Types is still not super good though
ptbrowne
force-pushed
the
feat/improvements
branch
from
0d097a2 to
37a7091
Compare
wereHamster
reviewed
Mar 24, 2023
wereHamster
reviewed
Apr 21, 2023
| draft.format = query.format; | ||
| } | ||
| const { query } = req; | ||
| const options = parseOptions(req, res)!; |
Member
There was a problem hiding this comment.
The parseOptions function ends the response (and if it does it returns undefined). So if options is undefined the handler should exit, otherwise it'll try to write into an already closed response.
| ); | ||
| const { query } = req; | ||
| const options = parseOptions(req, res)!; | ||
| const { format, shapes, year } = options; |
Member
There was a problem hiding this comment.
Don't use the non-null assertion operator when there is a reasonable way to avoid. Here check for undefined return value and exit handler.
| download: t.union([t.undefined, t.string]), | ||
| }); | ||
|
|
||
| export const parseOptions = (req: NextApiRequest, res: NextApiResponse) => { |
Member
There was a problem hiding this comment.
Suggested change
| export const parseOptions = (req: NextApiRequest, res: NextApiResponse) => { | |
| export const parseOptions = (req: NextApiRequest, res: NextApiResponse): undefined | Options => { |
| import produce from "immer"; | ||
| import * as t from "io-ts"; | ||
| import { NextApiRequest, NextApiResponse } from "next"; | ||
| import { defaultOptions, Shape } from "src/shared"; |
Member
There was a problem hiding this comment.
Suggested change
| import { defaultOptions, Shape } from "src/shared"; | |
| import { defaultOptions, Options, Shape } from "src/shared"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original goal was to separate the dynamic generation out of the API so
that it could be used as a library function.
Then I noticed that there was two different methods to
generateandtwo different APIs, while the difference seemed small.
I refactored both files to better separate http param handling from
generation, made the generate function more generic (accepting the
mapshaper commands), improved the capacity the ability to style SVGs,
now it is possible to ask for municipalities and countries on the SVG
generation.
Now I wonder why is the
api/generatefor ? Is it still used, is therea mean to test it ? @shuaiey would you know ?