-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zendesk support #52
Draft
kibin
wants to merge
3
commits into
master
Choose a base branch
from
feature/zd_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
zendesk support #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibin
commented
Jun 9, 2023
"prepublish": "yarn clean && yarn lint && yarn test && yarn build", | ||
"build_old": "yarn build_pack; yarn build_dist", | ||
"build": "run-s build_pack build_dist", | ||
"prepublish": "yarn clean && yarn lint && yarn build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed tests, because without api key they don't work, and so yarn@3 can't pack it directly from github
kibin
commented
Jun 9, 2023
@@ -1,7 +1,7 @@ | |||
/* global window */ | |||
'use strict' | |||
|
|||
const VERSION = '1.0.3' | |||
const VERSION = '1.0.3-f' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: fix when master branch is published
this allows to use nodejs with non-standart environments (zendesk, telligent) where there's no direct acces to the fetch or https , but the application provides special request API
8d86189
to
7e6a1ee
Compare
367bb22
to
7e6a1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open it here as draft PR for more transparency. This branch is used in Zendesk app by default.
Do not merge unless necessary