-
Notifications
You must be signed in to change notification settings - Fork 58
[CI] Switch to LTS2 for CICD tests #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mengfei25 let's do a comprehensive CI test before merge |
3446988
to
1b45255
Compare
Sure, will run them. |
97da161
to
d6d05ae
Compare
fe47372
to
2f3224d
Compare
This reverts commit 2f3224d.
needs: prepare | ||
container: | ||
image: mengfeili/intel-pvc-driver:1146-1136 | ||
image: intelgpu/driver-lts2:1146 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to use intelgpu/OS_NAME-OS_VERSION-Driver_Type:Diver_VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Dockerfile and dedicated docker image build workflow in this PR also
@chuanqi129 Please help review. |
inputs: | ||
runner: | ||
type: string | ||
default: 'pvc_rolling' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check whether we can use public runners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
--build-arg XPU_DRIVER_TYPE=${{ inputs.driver }} \ | ||
-f ubuntu/Dockerfile | ||
docker images | ||
- name: Push image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should login before image push
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.ci/docker/ubuntu/Dockerfile
Outdated
|
||
ENV DEBIAN_FRONTEND noninteractive | ||
|
||
ENV http_proxy http://proxy-dmz.intel.com:912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need those proxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
.ci/docker/ubuntu/Dockerfile
Outdated
|
||
FROM ubuntu:${UBUNTU_VERSION} | ||
|
||
ARG UBUNTU_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
.ci/docker/ubuntu/Dockerfile
Outdated
|
||
# Cleanup package manager | ||
RUN apt-get autoclean && apt-get clean | ||
RUN rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge those apt steps as one layer, and include the libnl-genl-3-200
for distribute use in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
docker pull limitation
https://docs.docker.com/docker-hub/usage/
disable_build