Skip to content

[wip] merge oneccl v1&v2 api #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[wip] merge oneccl v1&v2 api #1579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d4c62e9
merge oneccl v1&v2 api
Chao1Han Apr 15, 2025
d7093d2
update
Chao1Han Apr 16, 2025
3a816eb
update
Chao1Han Apr 16, 2025
15d2882
update
Chao1Han Apr 16, 2025
aef41b4
update
Chao1Han Apr 16, 2025
f973dc6
also find v1
Chao1Han Apr 16, 2025
32329f7
log
Chao1Han Apr 16, 2025
2aff57e
add send/recv gather
Chao1Han Apr 17, 2025
ded3fcb
add sactter
Chao1Han Apr 17, 2025
f0f1161
add broadcast, allreduce_coalesced, reduce
Chao1Han Apr 18, 2025
dff8d1a
add allgather, reduce_scatter
Chao1Han Apr 18, 2025
760e6a5
alltoall
Chao1Han Apr 18, 2025
8b53af0
split imple
Chao1Han Apr 18, 2025
9409a49
update
Chao1Han Apr 18, 2025
dc7200a
add log
Chao1Han Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cmake/Modules/FindXCCL.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,14 @@ find_library(
NO_DEFAULT_PATH
)

if((NOT XCCL_INCLUDE_DIR) OR (NOT XCCL_LIBRARY_DIR) OR (NOT XCCL_LIBRARY))
find_file(
XCCL_LIBRARY_1_0
NAMES libccl.so.1.0
HINTS ${XCCL_LIBRARY_DIR}
NO_DEFAULT_PATH
)

if((NOT XCCL_INCLUDE_DIR) OR (NOT XCCL_LIBRARY_DIR) OR (NOT XCCL_LIBRARY) OR (NOT XCCL_LIBRARY_1_0))
set(XCCL_FOUND False)
set(XCCL_NOT_FOUND_MESSAGE "OneCCL library not found!!")
return()
Expand All @@ -63,6 +70,6 @@ SET(CMAKE_LIBRARY_PATH ${CMAKE_LIBRARY_PATH}
find_package_handle_standard_args(
XCCL
FOUND_VAR XCCL_FOUND
REQUIRED_VARS XCCL_INCLUDE_DIR XCCL_LIBRARY_DIR XCCL_LIBRARY
REQUIRED_VARS XCCL_INCLUDE_DIR XCCL_LIBRARY_DIR XCCL_LIBRARY XCCL_LIBRARY_1_0
REASON_FAILURE_MESSAGE "${XCCL_NOT_FOUND_MESSAGE}"
)
2 changes: 1 addition & 1 deletion cmake/XCCL.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ if(NOT __XCCL_INCLUDED)
${XCCL_INCLUDE_DIR})
set_property(
TARGET torch::xccl PROPERTY INTERFACE_LINK_LIBRARIES
${XCCL_LIBRARY})
${XCCL_LIBRARY} ${XCCL_LIBRARY_1_0})
endif()
Loading
Loading