[WIP] Add mkl::linalg_lu relative Ops #1563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuiYifeng
requested changes
May 8, 2025
| Tensor& self_, | ||
| Tensor& pivots_, | ||
| std::vector<int32_t>& infos_) { | ||
| #ifdef USE_ONEMKL |
There was a problem hiding this comment.
Since BatchLinearAlgebra.cpp is wrapped by USE_ONEMKL, we can remove USE_ONEMKL from functions.
| const Tensor& pivots_, | ||
| std::vector<int32_t>& infos_, | ||
| TransposeType t) { | ||
| #ifdef USE_ONEMKL |
| } | ||
|
|
||
| template <> | ||
| int64_t mkl_getri_scratchpad<c10::complex<float>>( |
There was a problem hiding this comment.
The specialization of templates introduces redundancy. We'd better refine it in another PR.
Comment on lines
+1222
to
+1214
| // if (LU_new.has_value()) | ||
| LU.copy_(LU_use); | ||
| // return std::tuple<Tensor&, Tensor&, Tensor&>(LU, pivots, info); |
There was a problem hiding this comment.
Please remove debug code.
Comment on lines
68
to
69
| REGISTER_XPU_DISPATCH(lu_solve_stub, &native::xpu::lu_solve_mkl); | ||
| REGISTER_XPU_DISPATCH(lu_factor_stub, &native::xpu::lu_factor_mkl); |
There was a problem hiding this comment.
Before build with oneMKL XPU is default ON, we still need fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #1511