Skip to content

Fix logger subscription cleanup on reconfiguration #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix logger subscription cleanup on reconfiguration #14

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
20ca5a1
Fix logger subscription cleanup on reconfiguration
cnaples79 Sep 29, 2025
99b8c66
Fix CI error and add comprehensive test for logger cleanup
cnaples79 Sep 29, 2025
54384c9
Update rohd_bridge_logger_test.dart
cnaples79 Sep 29, 2025
bbd1fe0
Update rohd_bridge_logger_test.dart
cnaples79 Sep 29, 2025
b59d830
Update rohd_bridge_logger_test.dart
cnaples79 Sep 30, 2025
9163264
Apply dart format to rohd_bridge_logger_test.dart only
cnaples79 Sep 30, 2025
b6f95af
Fix logger lint errors
cnaples79 Oct 1, 2025
90a4fdd
style: apply dart format to rohd_bridge_logger.dart
cnaples79 Oct 2, 2025
b866cdd
style: fix line length to meet 80-character limit
cnaples79 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/src/rohd_bridge_logger.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ abstract class RohdBridgeLogger {
bool continueOnError = false,
bool enableDebugMesage = false,
}) {
// Clean up existing logger subscriptions and file sink
Logger.root.clearListeners();
Copy link
Contributor

@mkorbel1 mkorbel1 Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice this before, but I think we actually want to capture the StreamSubscription returned by Logger.root.onRecord.listen and cancel that, rather than clear all the listeners on Logger.root. It is possible that users would have been adding their own listeners to Logger.root for other purposes.

fileSink?.close();
fileSink = null;

RohdBridgeLogger.continueOnError = continueOnError;
Logger.root.level = rootLevel;
_printLevel = printLevel;
Expand Down
Loading