[MLIR] Remove spurious space when printing prop-dict (#145962)
#180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrotuna
reviewed
Nov 19, 2025
BogdanDragosV
force-pushed
the
dragosva/fix_prop_dict_print
branch
from
a9ebfac to
aeb656f
Compare
andrey-golubev
approved these changes
Nov 19, 2025
When there is an elided properties, there use to be an extra space insert in the prop-dict printing before the dictionnary. Fix #145695
Contributor
|
Let's wait CI results. Then I'll rebase-and-merge this one. Thanks! |
hrotuna
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of llvm/llvm-project#145962
When there is an elided properties, there use to be an extra space insert in the prop-dict printing before the dictionnary.
JIRA ticket
https://jira.devtools.intel.com/browse/EISW-190450
Related PR in NPU Compiler and/or OpenVINO repository with sub-module update
https://github.com/intel-innersource/applications.ai.vpu-accelerators.vpux-plugin/pull/22400
Other related tickets