Skip to content

Conversation

@AlexandruLorinti
Copy link
Contributor

Summary

Duplicate of PR merged on npu/release/19.x #151
Cherry-pick from upstream llvm llvm/llvm-project#147721; adding std::move to getChecked method.

JIRA ticket

  • E-105998

Related PR in NPU Compiler and/or OpenVINO repository with sub-module update

  • PR-xxx

Other related tickets

List tickets for additional work, eg, something was found during review but you agreed to address it in another Jira

  • E-xxxxx

Cherry-pick from upstream llvm: llvm/llvm-project#147721; adding std::move to getChecked method.
@AlexandruLorinti AlexandruLorinti requested a review from a team as a code owner November 7, 2025 14:50
@AlexandruLorinti AlexandruLorinti marked this pull request as draft November 7, 2025 15:01
@AlexandruLorinti
Copy link
Contributor Author

Updated expected copy count from "1" to "2" for CopyCountGet and CopyCountGetChecked tests, as there are currently 2 copies generated, while in previous npu-plugin-llvm there was just 1 copy generated.

In current npu-plugin-llvm as well as in upstream llvm there are 2 copies as the test calls first verifyInvariants which internally calls verify, in mlir/include/mlir/IR/StorageUniquerSupport.h:201

if (failed(ConcreteT::verifyInvariants(emitErrorFn, args...)))

@AlexandruLorinti AlexandruLorinti marked this pull request as ready for review November 10, 2025 10:41
@andrey-golubev andrey-golubev merged commit f85ae16 into intel:npu/release/20.x Nov 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants